Update UI for example projects #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feeloor
reviewed
Nov 25, 2019
Contributor
feeloor
left a comment
feeloor
left a comment
There was a problem hiding this comment.
Looks good overall, just minor comments.
src/styles.css
Outdated
|
|
||
|
|
||
|
|
||
| ; |
Contributor
There was a problem hiding this comment.
Can we remove the spacing here?
src/styles.css
Outdated
| /* body { | ||
| background: #f1e0ff; | ||
| } | ||
| } */ |
Contributor
There was a problem hiding this comment.
Is there a reason we want to remove this? If we are commenting it out can we just remove it completely instead?
* refactored header into a shared component for reusability
sumitarora
approved these changes
Nov 26, 2019
Member
sumitarora
left a comment
sumitarora
left a comment
There was a problem hiding this comment.
Apart from minor changes mentioned already. LGTM
Contributor
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated ui for the example projects.
Closes #95